Add SyncService client from EGW for embedded calling from Data API#2405
Merged
tatu-at-datastax merged 30 commits intomainfrom Apr 1, 2026
Merged
Add SyncService client from EGW for embedded calling from Data API#2405tatu-at-datastax merged 30 commits intomainfrom
tatu-at-datastax merged 30 commits intomainfrom
Conversation
Contributor
📉 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
tatu-at-datastax
changed the title
Contributor
Author
|
Ready for some review; not sure how to test. |
Hazel-Datastax
approved these changes
Mar 31, 2026
| && Objects.equals( | ||
| apiException.code, | ||
| EmbeddingProviderException.Code | ||
| .EMBEDDING_GATEWAY_UNABLE_RESOLVE_AUTHENTICATION_TYPE |
Contributor
There was a problem hiding this comment.
nit: no EMBEDDING_GATEWAY anymore. But I think it's not urgent, maybe update it later
Contributor
Author
There was a problem hiding this comment.
Yes -- there is SyncServiceErrorMessageMapper that needs to be rewritten to replace this exception type.
| && Objects.equals( | ||
| apiException.code, | ||
| EmbeddingProviderException.Code | ||
| .EMBEDDING_GATEWAY_UNABLE_RESOLVE_AUTHENTICATION_TYPE |
Contributor
There was a problem hiding this comment.
nit: EMBEDDING_GATEWAY
| .formatted(firstError.errorId(), firstError.message()); | ||
| logger.error(msg); | ||
| throw EmbeddingProviderException.Code | ||
| .EMBEDDING_GATEWAY_UNABLE_RESOLVE_AUTHENTICATION_TYPE |
Contributor
There was a problem hiding this comment.
nit: EMBEDDING_GATEWAY
| if (response.getStatus() == Response.Status.REQUEST_TIMEOUT.getStatusCode() | ||
| || response.getStatus() == Response.Status.GATEWAY_TIMEOUT.getStatusCode()) { | ||
|
|
||
| return EmbeddingProviderException.Code.EMBEDDING_GATEWAY_UNABLE_RESOLVE_AUTHENTICATION_TYPE |
Contributor
There was a problem hiding this comment.
nit: EMBEDDING_GATEWAY in this file
| List<String> credNames = new ArrayList<>(); | ||
| List<Uni<Map<String, String>>> resolveUnis = new ArrayList<>(); | ||
|
|
||
| for (Map.Entry<String, String> entry : authentication.entrySet()) { |
Contributor
There was a problem hiding this comment.
Great improvement! Original code only resolves one cred
| } | ||
|
|
||
| @Test | ||
| @Disabled("Requires SyncService (localhost:8084) for SHARED_SECRET credential validation") |
Contributor
Author
There was a problem hiding this comment.
Formerly non-EGW path did not call Sync Service at all; now does: would either need to Mock Sync Service, or allow configuring by-passing it or something.
But key format validation is now tested in SyncServiceCredentialResolvingProviderTest
Hazel-Datastax
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Embeds sync-service validation call code from EGW into Data API, to prepare for removal of EGW
Which issue(s) this PR fixes:
Part of #2387
Checklist